Refactor the extraperfect library inclusion
#4592
Draft
+11
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
package: GAP
release notes: not needed
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in oscar-system/GAP.jl#1162 (comment).
This currently contains #4591 and will be rebased once that is merged.
The test will probably work, since the two extraperfect files are injected into gaproots that are managed by GAP.jl. To clean them up and thus be able to really test this, one needs to run something like
rm -r JULIA_DEPOT_PATH/scratchspaces/c863536a-3901-11e9-33e7-d5cd0df7b904/*/grp(This won't do any harm as Oscar versions without this PR will re-create them on startup.)The reason that this won't work right now is that the root directory introduced in #4591 is not available at GAP's startup and thus not known to the kernel. However, in https://github.com/gap-system/gap/blob/222f357de5001b0e1c1ce60b8d1b7b45a1c4a32d/grp/perf.grp#L42 a kernel function is used to load the files. See gap-system/gap#5938 for a patch in GAP that fixes that.