Allow loading of extraperfect files from all root dirs #5938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former code for loading perf27.grp and perf33.grp tried to load them using
READ_GAP_ROOT
which only checks the root directories inSyGapRootPaths
aka the root paths that are known at GAP's startup e.g. via the-l
flag.However, this won't check any root directories that were added later using
ExtendRootDirectories
.This PR changes this to check all root directories in
GAPInfo.RootPaths
. The motivation for this is in OSCAR, where we want the julia lazy artifact handler to do the downloading of these files on first access, but due to how julia loads OSCAR and GAP.jl, this seems to be only possible usingExtendRootDirectories
. (x-ref oscar-system/Oscar.jl#4592)cc @fingolfin @ThomasBreuer