Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Lie module serialization cleanup #4123

Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Sep 19, 2024

Made possible by #4120.

Currently includes #4120, I'll rebase once that is merged.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (979624b) to head (f2082bc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
- Coverage   84.67%   84.67%   -0.01%     
==========================================
  Files         626      626              
  Lines       84249    84249              
==========================================
- Hits        71342    71340       -2     
- Misses      12907    12909       +2     
Files with missing lines Coverage Δ
experimental/LieAlgebras/src/serialization.jl 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@lgoettgens lgoettgens merged commit 2dc5df5 into oscar-system:master Sep 20, 2024
28 checks passed
@lgoettgens lgoettgens deleted the lg/Lie-serialization-attrs branch September 20, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code serialization topic: LieAlgebras
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants