Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group attribute saving #4120

Merged
merged 3 commits into from
Sep 19, 2024
Merged

group attribute saving #4120

merged 3 commits into from
Sep 19, 2024

Conversation

antonydellavecchia
Copy link
Collaborator

Storing Gap groups with their attributes

src/Serialization/Groups.jl Outdated Show resolved Hide resolved
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@antonydellavecchia antonydellavecchia merged commit 979624b into master Sep 19, 2024
26 checks passed
@antonydellavecchia antonydellavecchia deleted the adv/group-attrs branch September 19, 2024 15:58
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (6a7407f) to head (985303a).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4120   +/-   ##
=======================================
  Coverage   84.66%   84.66%           
=======================================
  Files         626      626           
  Lines       84217    84240   +23     
=======================================
+ Hits        71299    71320   +21     
- Misses      12918    12920    +2     
Files with missing lines Coverage Δ
src/Serialization/Groups.jl 98.80% <100.00%> (+0.37%) ⬆️
src/Serialization/main.jl 85.93% <100.00%> (+0.05%) ⬆️
src/Serialization/serializers.jl 99.18% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants