Lie algebras: Add root system detection #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4084 +/- ##
==========================================
- Coverage 84.69% 84.67% -0.02%
==========================================
Files 614 626 +12
Lines 83568 84208 +640
==========================================
+ Hits 70780 71307 +527
- Misses 12788 12901 +113
|
lgoettgens
force-pushed
the
lg/Lie-root-system-detection
branch
from
1bc15ba
to
11ceb45
Compare
lgoettgens
force-pushed
the
lg/Lie-root-system-detection
branch
from
59bd0e5
to
d778378
Compare
fingolfin
approved these changes
Sep 17, 2024
|
Let's wait for another few days with merging for @felix-roehrich to have the chance to have a look as well |
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
lgoettgens
force-pushed
the
lg/Lie-root-system-detection
branch
from
1655206
to
b46fb11
Compare
lgoettgens
commented
Sep 18, 2024
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
felix-roehrich
approved these changes
Sep 18, 2024
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
root_system(L::LieAlgebra)that either returns a cached root system or tries to compute the root system ofL.The remaining changes are either subroutines needed to implement the former, or some few places where using this new functionality made the code a lot cleaner.
For my convenience and to limit potential conflicts, this currently contains #4053. Once #4053 is merged, I'll rebase this PR.