Lie algebras: more progress #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
lgoettgens
force-pushed
the
lg/coxeter
branch
4 times, most recently
from
c9f266e
to
3640a14
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4053 +/- ##
==========================================
+ Coverage 84.64% 84.76% +0.11%
==========================================
Files 612 614 +2
Lines 83250 83966 +716
==========================================
+ Hits 70469 71170 +701
- Misses 12781 12796 +15
|
lgoettgens
force-pushed
the
lg/coxeter
branch
from
3640a14
to
cd9043c
Compare
lgoettgens
force-pushed
the
lg/coxeter
branch
from
18f00d5
to
972c8ff
Compare
fingolfin
reviewed
Sep 10, 2024
fingolfin
reviewed
Sep 10, 2024
Co-authored-by: Max Horn <max@quendi.de>
fingolfin
reviewed
Sep 10, 2024
felix-roehrich
suggested changes
Sep 16, 2024
| @@ -1431,11 +1431,65 @@ function dim_of_simple_module(L::LieAlgebra, hw::Vector{<:IntegerUnion}) | |||
| end | |||
|
|
|||
| @doc raw""" | |||
| dominant_character(L::LieAlgebra{C}, hw::Vector{Int}) -> Dict{Vector{Int}, Int} | |||
| dominant_weights([T,] L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} | |||
There was a problem hiding this comment.
Suggested change
| dominant_weights([T,] L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} | |
| dominant_weights([T = Vector{Int}], L::LieAlgebra{C}, hw::Vector{<:IntegerUnion}) -> Vector{T} |
There was a problem hiding this comment.
I did not want to specify this at this point, as I want to straight out all of the return types in the near future. That's also the reason for the many `The return type will change in the future" in docstrings.
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains the following changes/additions:
isomorphism(FPGroup, ::WeylGroup)via Coxeter relations. Already known information likeis_finiteandordergets set in the result as well to allow for better handling in GAP.dot(::WeightLatticeElem, ::WeightLatticeElem)dominant_character,character, andtensor_product_decompositionnow use the root system, if available, and only fall back to GAP otherwise. (@benlorenz this should resolve the rest of cases of Make LieAlgebraModule tests better gc-able #3913 (comment))This is still a draft since I would like to wait for #4036 to get merged first to avoid conflicts.