Semicolon before kwargs #2618
Semicolon before kwargs #2618
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2618 +/- ##
==========================================
+ Coverage 72.04% 72.13% +0.09%
==========================================
Files 429 429
Lines 60691 60536 -155
==========================================
- Hits 43722 43669 -53
+ Misses 16969 16867 -102
|
|
One can additionally remove duplicate names if the name of the kwarg and the name of the variable coincide, i.e. |
src/Rings/mpoly-graded.jl
Outdated
| end | ||
|
|
||
|
|
||
| # ============================================ | ||
| # 2023-06-30 START: New impl of homogenization | ||
| # By John Abbott, based on K+R Book vol 2 | ||
| # By John Abbott, based on K+R Book "Computational Commutative Algebra" (see "justification" below) |
There was a problem hiding this comment.
This PR seems to contain other changes beyond those advertised in the title?
It also has conflicts now...
Did you generate this with a script? If so, perhaps we can just redo this cleanly from latest master, with the script in the commit message (handy for future repetitions of this change)
There was a problem hiding this comment.
Should I look to see how scary "resolve conflicts" is?
JohnAAbbott
force-pushed
the
semicolon-before-kwargs
branch
from
ef66aca to
e2dfa57
Compare
|
Ahh! Not sure what I did. Hope it wasn't harmful. |
Ensured that all(?) calls (in
mpoly-affine-algebras.jl) specifying kwargs have a semicolon just before the first kwarg.Refer to discussion #2615