Homog ideal zm #2614
Merged
Homog ideal zm #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdecker
approved these changes
Aug 3, 2023
… Semicolons before kwargs (discussion #2615)
lgoettgens
reviewed
Aug 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2614 +/- ##
==========================================
+ Coverage 71.91% 72.12% +0.20%
==========================================
Files 429 429
Lines 60812 60818 +6
==========================================
+ Hits 43731 43863 +132
+ Misses 17081 16955 -126
|
OK, it's not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
OK, not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
OK, not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Aug 17, 2023
* homogenization for ideal with ZZ^m grading * Minor improvements; better comments * 20230630 faster ideal homogenization * Fixed 3 edge cases: 0 ideal, std graded, general ZZ^1 grading * Revised default pos for homogenizaing vars * Renamed: old impl is now homogenization_via_saturation; new is just homogenization * Improved homog (now for all gradings) * Avoid comouting GB in _gens_for_homog_via_sat * Removed some debug print stmts * Revised IO for homogenization (see discussion 2582) * Revised to new syntax/UI for specifying position * Further cleaning & tidying * Updated call to homogenization to new syntax * Updated method signatures for homogenization * Added justification for new algorithm; changed indentation * Fixed typo, & wrong reference * Removed option complete_reduction in call to groebner_basis * In homogenization(ideal): moved short-cut for ideal(1) to after ZZ^1. Semicolons before kwargs (discussion oscar-system#2615) * Homogenization: Added short-cuts for principal ideals * Tests for new homogenization * Update src/Rings/mpoly-graded.jl OK, it's not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> * Update src/Rings/mpoly-graded.jl OK, not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> * Update src/Rings/mpoly-graded.jl OK, not my code Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com> --------- Co-authored-by: Claus Fieker <fieker@mathematik.uni-kl.de> Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation with references to the underlying maths justifying the algorithms (earlier references were incomplete/misleading)