Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui node input attributes key added #3561

Merged
merged 5 commits into from
Oct 9, 2023
Merged

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Oct 9, 2023

Migrated from #3143

Pattern for UI to show error when code field has other characters than numeric.

Related issue(s)

Elements issue 78

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl self-assigned this Oct 9, 2023
@hperl hperl changed the title Hperl/fix input attributes fix: ui node input attributes key added Oct 9, 2023
@hperl hperl marked this pull request as ready for review October 9, 2023 08:06
@hperl hperl requested review from aeneasr and zepatrik as code owners October 9, 2023 08:06
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand how this fixes the issue where the email is the value of the code field 🤔
But the change makes sense in general.

@hperl
Copy link
Contributor Author

hperl commented Oct 9, 2023

I don't really understand how this fixes the issue where the email is the value of the code field 🤔 But the change makes sense in general.

I didn't look into the actual fix much except for getting the PR to pass on a current master.

@hperl hperl merged commit 9eff0f3 into master Oct 9, 2023
@hperl hperl deleted the hperl/fix-input-attributes branch October 9, 2023 10:14
@hperl hperl mentioned this pull request Oct 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants