Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui node input attributes key added #3143

Closed
wants to merge 3 commits into from

Conversation

misamu
Copy link
Contributor

@misamu misamu commented Mar 3, 2023

Pattern for UI to show error when code field has other characters than numeric.

Related issue(s)

Elements issue 78

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@misamu misamu requested review from aeneasr and zepatrik as code owners March 3, 2023 13:37
@misamu misamu mentioned this pull request Mar 3, 2023
6 tasks
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

selfservice/strategy/code/strategy_recovery.go Outdated Show resolved Hide resolved
@aeneasr
Copy link
Member

aeneasr commented Apr 13, 2023

To get tests passing, you'll need to update the snapshots. IIRC you can do this with make test-refresh or make refresh

@jonas-jonas
Copy link
Member

make test-update-snapshots updates the snapshots. :) Could maybe align that name with the other projects.

@misamu
Copy link
Contributor Author

misamu commented Apr 14, 2023

Running test-update-snapshots updates JSON with the pattern, but I get FAIL github.com/ory/kratos/selfservice/strategy/password and can't see any obvious reason for that failure.

@davidspek
Copy link

Is this still being worked on?

@hperl hperl self-assigned this Oct 9, 2023
@hperl
Copy link
Contributor

hperl commented Oct 9, 2023

Closed in favor of #3561

@hperl hperl closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants