Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customized DNS resolving for remote registry #696

Merged
merged 17 commits into from
Dec 23, 2022

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 21, 2022

Resolves #688

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Merging #696 (1b3dcb1) into main (42f62e0) will increase coverage by 0.41%.
The diff coverage is 78.00%.

@@            Coverage Diff             @@
##             main     #696      +/-   ##
==========================================
+ Coverage   72.23%   72.64%   +0.41%     
==========================================
  Files          14       15       +1     
  Lines         515      563      +48     
==========================================
+ Hits          372      409      +37     
- Misses        114      123       +9     
- Partials       29       31       +2     
Impacted Files Coverage Δ
internal/net/net.go 50.00% <50.00%> (ø)
cmd/oras/internal/option/remote.go 68.29% <85.00%> (+4.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft November 21, 2022 03:47
@qweeah qweeah changed the title feat: support customized DNS resolving for remote registry [WIP] feat: support customized DNS resolving for remote registry Nov 21, 2022
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review November 21, 2022 05:29
@qweeah qweeah changed the title [WIP] feat: support customized DNS resolving for remote registry feat: support customized DNS resolving for remote registry Nov 21, 2022
@qweeah qweeah added the enhancement New feature or request label Nov 23, 2022
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
cmd/oras/internal/option/remote.go Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 3ad6eee into oras-project:main Dec 23, 2022
TerryHowe pushed a commit to TerryHowe/oras that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support customized DNS resolving from a host to a specific address
3 participants