Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customized DNS resolving from a host to a specific address #688

Closed
1 task done
qweeah opened this issue Nov 14, 2022 · 2 comments · Fixed by #696
Closed
1 task done

Support customized DNS resolving from a host to a specific address #688

qweeah opened this issue Nov 14, 2022 · 2 comments · Fixed by #696
Assignees
@qweeah
Labels
enhancement New feature or request
Milestone
v1.0.0-rc.2

Comments

@qweeah
Copy link
Contributor

qweeah commented Nov 14, 2022 •
edited
Loading

What is the version of your ORAS CLI

No response

What would you like to be added?

I would like to have a new flag added to all remote registry related commands:

--resolve <host:port:address>

So any outgoing request towards host:port should be resolve to address:port.

Why is this needed for ORAS?

So ORAS can be 1) used to debug registry services running locally; 2) hardcode DNS resolving to reduce DNS bouncing in geo-replicated registry services.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@qweeah qweeah added the enhancement New feature or request label Nov 14, 2022
@qweeah qweeah added this to the v1.0.0 milestone Nov 14, 2022
@FeynmanZhou
Copy link
Member

Should we make this flag --resolve a global option? I assume it can resolve only one address per request.

@qweeah
Copy link
Contributor Author

qweeah commented Nov 14, 2022 •
edited
Loading

Should we make this flag --resolve a global option? I assume it can resolve only one address per request.

No we shouldn't. ORAS has a different option management mechanism. This flag will be added to the remote type in option package package and any command relevant to remote registry operation will have this flag.

@qweeah qweeah changed the title Support customized DNS resolving from a host and port pair to a specific address Support customized DNS resolving from a host to a specific address Nov 14, 2022
@qweeah qweeah mentioned this issue Nov 21, 2022
Merged
shizhMSFT pushed a commit that referenced this issue Dec 23, 2022
@qweeah
feat: support customized DNS resolving for remote registry (#696)
3ad6eee 
Resolves #688

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
TerryHowe pushed a commit to TerryHowe/oras that referenced this issue Feb 2, 2023
@qweeah
feat: support customized DNS resolving for remote registry (oras-proj…
04bf67f 
…ect#696)

Resolves oras-project#688

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah mentioned this issue Mar 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qweeah qweeah

Labels
enhancement New feature or request
Projects
No open projects
ORAS-Planning
Status: Done
Milestone
v1.0.0-rc.2
Development

Successfully merging a pull request may close this issue.

feat: support customized DNS resolving for remote registry qweeah/oras
2 participants
@qweeah @FeynmanZhou