-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: push an ORAS artifact manifest when no blob is specified #486
Conversation
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
Signed-off-by: Haoliang Yue <yuehaoliang@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #486 +/- ##
=======================================
Coverage 55.69% 55.69%
=======================================
Files 6 6
Lines 237 237
=======================================
Hits 132 132
Misses 90 90
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@shizhMSFT @FeynmanZhou - it would be good to start discussing how the ORAS CLI and library can start thinking about using the OCI artifact manifest as well. Having it default to ORAS artifact might make it hard to switch to the OCI artifact manifest if that is approved. Can we explore what options we have here
All of these have pros and cons and starting that discussion might be useful before switching push to use the artifact spec as default. |
@sajayantony This issue / PR is based on @SteveLasker 's feedback that OCI manifest does not support empty layer array in terms of spec. That's why ORAS artifact manifest becomes the only choice. |
Yes I understand the decision. I’m asking how do we plan to change the default to use the OCI manifest if that would become the preferred way. Basically consider how the we keep compatibility with ORAS manifest later. |
@sajayantony , are you asking about the pending OCI manifest changes? |
Since we will support OCI manifest & OCI Artifact (opencontainers/image-spec#934), let's postpone this change. |
Let's re-open this PR if needed later. |
The CLI IX is pretty important for the annotations, without blobs scenarios. |
Closing again as oras-project/oras-go#271 is planned. |
Resolve #466
Signed-off-by: Haoliang Yue yuehaoliang@microsoft.com