Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OCI Artifact from ORAS Artifact #271

Closed
7 tasks done
shizhMSFT opened this issue Aug 18, 2022 · 9 comments
Closed
7 tasks done

Migrate to OCI Artifact from ORAS Artifact #271

shizhMSFT opened this issue Aug 18, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Aug 18, 2022

We will migrate to OCI Artifact from ORAS Artifact once the following PRs are merged.

Tasks:

This issue covers #267 and #268.

@sajayantony
Copy link
Contributor

sajayantony commented Aug 26, 2022

Should we start a new branch for OCI now that you have go structs for OCI. Similarly, for oras - CLI?
/cc @nima @michaelb990 @shizhMSFT

@rdpsin
Copy link

rdpsin commented Aug 31, 2022

Any update on this work?

@Wwwsylvia
Copy link
Member

@rdpsin We will be working on this after releasing oras-go v2.0.0-rc3, which is scheduled for Sep. 5th.

@SteveLasker
Copy link
Contributor

Just a clarification that we'll need to maintain support for ORAS artifacts, until all registries have migrated to the OCI Artifact spec.

  1. Check if /referrers is supported (best future case)
  2. Check if _oras/referrers is supported (limited time, as ACR, ECR and Zot migrate to /referrers)
  3. Fallback to using OCI Image manifest, with a refers/subject property (see Rename refers field to subject #950)

@shizhMSFT
Copy link
Contributor Author

Just a clarification that we'll need to maintain support for ORAS artifacts, until all registries have migrated to the OCI Artifact spec.

  1. Check if /referrers is supported (best future case)
  2. Check if _oras/referrers is supported (limited time, as ACR, ECR and Zot migrate to /referrers)
  3. Fallback to using OCI Image manifest, with a refers/subject property (see Rename refers field to subject #950)

The initial iteration will not have the fallback to ORAS Artifact referrers. The fallback will be added in the second iteration after proper discussions.

@sajayantony
Copy link
Contributor

Oras needs to consume RC2 since it includes the subject field - opencontainers/image-spec#958

@michaelb990
Copy link

The fallback will be added in the second iteration after proper discussions.

What fallback are we talking about here? From what I read, it seemed like falling back to ORAS Artifacts wouldn't be compatible with the tag-based fallback already proposed in the OCI distribution-spec, now an RC.

@sajayantony
Copy link
Contributor

On the call today we discussed that the fall back to ORAS is not going to be supported. This issues needs to be updated to reflect that and the next update to the libraries will remove the ORAS artifact types and move to OCI with OCI image fallback.

@shizhMSFT
Copy link
Contributor Author

Closing as all sub tasks are resolved.

Repository owner moved this from Todo to Done in ORAS-Planning Oct 31, 2022
@shizhMSFT shizhMSFT unpinned this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
6 participants