feat: add resolve command #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajayantony
requested review from
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1187 +/- ##
==========================================
+ Coverage 80.09% 80.34% +0.25%
==========================================
Files 65 66 +1
Lines 3572 3618 +46
==========================================
+ Hits 2861 2907 +46
Misses 497 497
Partials 214 214 ☔ View full report in Codecov by Sentry. |
FeynmanZhou
reviewed
Nov 15, 2023
|
Thanks @sajayantony . Could you associate the original issue #907 with this PR? |
qweeah
reviewed
Nov 15, 2023
qweeah
reviewed
Nov 15, 2023
qweeah
reviewed
Nov 15, 2023
qweeah
reviewed
Nov 15, 2023
qweeah
reviewed
Nov 15, 2023
…tput Signed-off-by: amands98 <amandeepsm.in@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Co-authored-by: Feynman Zhou <feynman@kubesphere.io> Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Sajay Antony <sajaya@microsoft.com>
|
Closes #907 |
1 task
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 11, 2024
Signed-off-by: amands98 <amandeepsm.in@gmail.com> Co-authored-by: Billy Zha <qweeah@gmail.com> Co-authored-by: Feynman Zhou <feynman@kubesphere.io> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is an update with a test and flags based of PR from @amands98.
@amands98 if you would like to combine these commits I'm more than happy to send a PR to your branch.
Fixes #907.