feat: add command to get the digest of a tagged manifest without parsing output #1034
Conversation
…tput Signed-off-by: amands98 <amandeepsm.in@gmail.com>
amands98
requested review from
sajayantony,
shizhMSFT,
SteveLasker,
qweeah and
TerryHowe
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #1034 +/- ##
==========================================
- Coverage 81.28% 80.56% -0.73%
==========================================
Files 57 58 +1
Lines 2907 2948 +41
==========================================
+ Hits 2363 2375 +12
- Misses 371 399 +28
- Partials 173 174 +1
|
| Args: cobra.ExactArgs(1), | ||
| Aliases: []string{"digest"}, | ||
| PreRunE: func(cmd *cobra.Command, args []string) error { | ||
| opts.RawReference = args[0] |
There was a problem hiding this comment.
Should validate the reference is in form of <name>:<tag>
| var opts resolveOptions | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "resolve [flags] <name>:<tag>", |
There was a problem hiding this comment.
This command should be experimental, please check how other commands do it, e.g. oras discover
There was a problem hiding this comment.
Also we need E2E tests, @amands98 can you add some for this command via following https://github.com/oras-project/oras/blob/main/test/e2e/README.md
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Aman <136564604+amands98@users.noreply.github.com>
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Signed-off-by: Terry Howe <tlhowe@amazon.com>
|
Would love to get command before we release 1.2. @amands98 do you need help to finish this up? |
|
Leaving this here since I think there have been multiple users who have wanted this command - #1187 |
Note :
I will add the description shortly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #907
Please check the following list: