-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9155] fix(utils): logging correct error message in HTTP requests #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added some NITs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes suggested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ts (#374) * Fixed error being logged in HTTP requests * Added test for logged errors * Improve test error checking + comments * Fix unnecessary re-cast in Error * Update copyright dates in headers * add review changes * Update bad url example --------- Co-authored-by: Sean Pfeifer <pfeifer.sean.a@gmail.com>
Summary
Issues