-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9360] fix(utils): logging correct error message in HTTP requests #329
Conversation
The Travis CI $ mkdir $HOME/travisci-tools && pushd $HOME/travisci-tools && git init && git pull https://$CI_USER_TOKEN@github.com/optimizely/travisci-tools.git && popd
~/travisci-tools ~/build/optimizely/go-sdk
hint: ... (omitted for log brevity)
Initialized empty Git repository in /home/travis/travisci-tools/.git/
remote: Repository not found.
fatal: Authentication failed for 'https://github.com/optimizely/travisci-tools.git/'
The command "mkdir $HOME/travisci-tools && pushd $HOME/travisci-tools && git init && git pull https://$CI_USER_TOKEN@github.com/optimizely/travisci-tools.git && popd" failed and exited with 1 during . From these logs it looks like something may be missing / misconfigured with Travis or the |
Hi @seanpfeifer, thanks for opening this PR! Can you please update your branch with master? |
Merged and tested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Mentioning @yasirfolio3 for a final check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you please update the headers with the current year 2023
in both files.
Updated! |
Hi, the fix is merged here. #374 Thank you for your contribution! |
This is currently set to always log a
nil
error using the unset return parametere
, instead of the actual error that gets assigned todoErr
.This change will allow users to see the HTTP error in these messages.
Submissions info