Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge): use VTEP IP instead of hard-coded #147

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Aug 31, 2023

Fixes #83

Blocked by opiproject/opi-api#349

Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com

@glimchb glimchb added the bug Something isn't working label Aug 31, 2023
@glimchb glimchb added Merge Candidate in the open merge window, next candidate for merge and removed bug Something isn't working labels Sep 5, 2023
@glimchb glimchb marked this pull request as ready for review September 5, 2023 13:26
@glimchb glimchb requested a review from a team as a code owner September 5, 2023 13:26
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #147 (f8717cb) into main (1ff6939) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head f8717cb differs from pull request most recent head 9ec6c92. Consider uploading reports for the commit 9ec6c92 to get more accurate results

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   48.00%   47.94%   -0.07%     
==========================================
  Files           5        5              
  Lines         852      851       -1     
==========================================
- Hits          409      408       -1     
  Misses        424      424              
  Partials       19       19              
Files Changed Coverage Δ
pkg/evpn/bridge.go 60.81% <100.00%> (-0.23%) ⬇️

Fixes opiproject#83

Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@@ -68,8 +68,7 @@ func (s *Server) CreateLogicalBridge(_ context.Context, in *pb.CreateLogicalBrid
}
// Example: ip link add vxlan-<LB-vlan-id> type vxlan id <LB-vni> local <vtep-ip> dstport 4789 nolearning proxy
myip := make(net.IP, 4)
// TODO: remove hard-coded 167772162 == "10.0.0.2"
binary.BigEndian.PutUint32(myip, 167772162)
binary.BigEndian.PutUint32(myip, in.LogicalBridge.Spec.VtepIpPrefix.Addr.GetV4Addr())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check for nil #150

@glimchb glimchb merged commit 7784b83 into opiproject:main Sep 5, 2023
19 checks passed
@glimchb glimchb deleted the vtep branch September 5, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateLogicalBridge what about hard coded IP 10.0.0.100 ?
1 participant