fix(bridge): use VTEP IP instead of hard-coded #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glimchb
force-pushed
the
vtep
branch
3 times, most recently
from
ff7379f
to
defe6fa
Compare
glimchb
added
Merge Candidate
glimchb
force-pushed
the
vtep
branch
2 times, most recently
from
e0587d7
to
f8717cb
Compare
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 48.00% 47.94% -0.07%
==========================================
Files 5 5
Lines 852 851 -1
==========================================
- Hits 409 408 -1
Misses 424 424
Partials 19 19
|
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
glimchb
commented
Sep 5, 2023
| @@ -68,8 +68,7 @@ func (s *Server) CreateLogicalBridge(_ context.Context, in *pb.CreateLogicalBrid | |||
| } | |||
| // Example: ip link add vxlan-<LB-vlan-id> type vxlan id <LB-vni> local <vtep-ip> dstport 4789 nolearning proxy | |||
| myip := make(net.IP, 4) | |||
| // TODO: remove hard-coded 167772162 == "10.0.0.2" | |||
| binary.BigEndian.PutUint32(myip, 167772162) | |||
| binary.BigEndian.PutUint32(myip, in.LogicalBridge.Spec.VtepIpPrefix.Addr.GetV4Addr()) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #83
Blocked by opiproject/opi-api#349
Signed-off-by: Boris Glimcher Boris.Glimcher@emc.com