-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CreateLogicalBridge
what about hard coded IP 10.0.0.100
?
#83
Comments
Yes @glimchb as I have explained before maybe this is something that is missing from the API as the VRF spec have VTEP IP but the LogicalBridgeSpec it doesn't. Maybe we need to add this VTEP IP field to the API or completely remove it also from the VRF spec and pass it in both cases through evpn-gw-br configuration files. I will need to discuss this with @JanScheurich before we do any changes to the API. For now when it comes to the LogicalBridges you can pass the VTEP IP through configuration in evpn-gw-br. |
thanks @mardim91 I will leave this issue open for tracking |
@JanScheurich please advise |
The optional VTEP IP is indeed missing from the LogicalBridgeSpec (We have it in the VrfSpec for L3 EVPN). It was simply forgotten when extending to the L2 EVPN use case. We never actually used it in our prototype because our server implementation had a default VTEP configured. Please go ahead and create an API PR to add the vtep_id_prefix as optional argument. |
opened opiproject/opi-api#349 please review |
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes opiproject#83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
Fixes #83 Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
I see no field for IP address
but
see hard-coded
opi-evpn-bridge/pkg/evpn/bridge.go
Lines 72 to 73 in b998cfe
@mardim91 please advise
The text was updated successfully, but these errors were encountered: