CreateLogicalBridge what about hard coded IP 10.0.0.100 ?

[glimchb]

I see no field for IP address

ip link add vni10 type vxlan id 10 local 10.0.0.100 dstport 4789 nolearning proxy
ip link set vni10 master br-tenant up
bridge vlan add dev vni10 vid 10 pvid untagged
bridge link set dev vni10 neigh_suppress on

but

message LogicalBridgeSpec {
    // the VLAN of the L2 domain
    uint32 vlan_id         = 1 [(google.api.field_behavior) = REQUIRED];
    //VXLAN VNI for the L2 EVPN. Also used as EVPN route target
    uint32 vni             = 2;
}

see hard-coded

opi-evpn-bridge/pkg/evpn/bridge.go

Lines 72 to 73 in b998cfe

	// TODO: remove hard-coded 167772162 == "10.0.0.2"
	binary.BigEndian.PutUint32(myip, 167772162)

@mardim91 please advise

[mardim91]

Yes @glimchb as I have explained before maybe this is something that is missing from the API as the VRF spec have VTEP IP but the LogicalBridgeSpec it doesn't. Maybe we need to add this VTEP IP field to the API or completely remove it also from the VRF spec and pass it in both cases through evpn-gw-br configuration files. I will need to discuss this with @JanScheurich before we do any changes to the API. For now when it comes to the LogicalBridges you can pass the VTEP IP through configuration in evpn-gw-br.

[glimchb]

thanks @mardim91 I will leave this issue open for tracking

[glimchb]

@JanScheurich please advise

[JanScheurich]

The optional VTEP IP is indeed missing from the LogicalBridgeSpec (We have it in the VrfSpec for L3 EVPN). It was simply forgotten when extending to the L2 EVPN use case. We never actually used it in our prototype because our server implementation had a default VTEP configured. Please go ahead and create an API PR to add the vtep_id_prefix as optional argument.

[glimchb]

opened opiproject/opi-api#349 please review