-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update renovate for buf gen package versions #435
Changes from 3 commits
6357d45
5648d19
5a966ce
fce6708
bdf8fd6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,30 @@ | |
"matchStrings": ["google-api-linter:(?<currentValue>.*?)\\s"], | ||
"datasourceTemplate": "docker", | ||
"depNameTemplate": "ghcr.io/docker-multiarch/google-api-linter" | ||
}, | ||
{ | ||
"fileMatch": ["(^|\\/)buf.work.yaml"], | ||
"matchStrings": ["grpc/python:(?<currentValue>.*?\\s"], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Haven't we missed "matchStrings": ["grpc/python:(?<currentValue>.*?)\\s"], for the deps below too |
||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "grpc/grpc" | ||
}, | ||
{ | ||
"fileMatch": ["(^|\\/)buf.work.yaml"], | ||
"matchStrings": ["protocolbuffers/python:(?<currentValue>.*?\\s"], | ||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "protocolbuffers/protobuf" | ||
}, | ||
{ | ||
"fileMatch": ["(^|\\/)buf.work.yaml"], | ||
"matchStrings": ["protocolbuffers/go:(?<currentValue>.*?\\s"], | ||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "protocolbuffers/protobuf-go" | ||
}, | ||
{ | ||
"fileMatch": ["(^|\\/)buf.work.yaml"], | ||
"matchStrings": ["grpc-ecosystem/gateway:(?<currentValue>.*?\\s"], | ||
"datasourceTemplate": "github-tags", | ||
"depNameTemplate": "grpc-ecosystem/grpc-gateway" | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,17 +1,17 @@ | ||
version: v1 | ||
plugins: | ||
- plugin: go | ||
- plugin: buf.build/protocolbuffers/go:v1.31.0 | ||
out: gen/go | ||
opt: paths=source_relative | ||
- plugin: go-grpc | ||
- plugin: buf.build/grpc/go:v1.3.0 | ||
out: gen/go | ||
opt: paths=source_relative | ||
- name: grpc-gateway | ||
- name: buf.build/grpc-ecosystem/gateway:v2.19.0 | ||
out: ./gen/go | ||
opt: paths=source_relative | ||
- plugin: buf.build/grpc/python:v1.59.2 | ||
out: gen/python | ||
- plugin: buf.build/protocolbuffers/python | ||
- plugin: buf.build/protocolbuffers/python:v25.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we also pin and update in renovate There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, lets go ahead and do that as it will allow for controlled and tracked changes based on tool updates. Pinning the different versions is directly doable from the buf.build plugin's. The renovate update for the go and grpc-gateway version can be mapped to the github-tags. The go-grpc is a managed function within the github grpc/grpc-go repository and can't be tracked by the github-tags. Will have to determine a method for renovate to track that specific function, perhaps from the google.golang.org site. I will open that as a separate issue to track and put the changes in for the pinning and two repo's for renovate operation. |
||
out: gen/python | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those deps are described in
buf.gen.yaml
file, notbuf.work.yaml
below as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh - yeah - I was looking at both files for different things and typed the wrong one.