Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update renovate for buf gen package versions #435

Merged
merged 5 commits into from
Jan 24, 2024
Merged

ci: update renovate for buf gen package versions #435

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6357d45
ci: update renovate for buf gen package versions
sandersms Jan 17, 2024
5648d19
Merge branch 'opiproject:main' into renovate-update
sandersms Jan 18, 2024
5a966ce
ci: add go, go-grpc, and grpc-gateway versions to generation
sandersms Jan 19, 2024
fce6708
fix(ci): incorrect filename in renovate
sandersms Jan 22, 2024
bdf8fd6
fix(ci): typo in new renovate checks
sandersms Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,30 @@
"matchStrings": ["google-api-linter:(?<currentValue>.*?)\\s"],
"datasourceTemplate": "docker",
"depNameTemplate": "ghcr.io/docker-multiarch/google-api-linter"
},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those deps are described in buf.gen.yaml file, not buf.work.yaml
below as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh - yeah - I was looking at both files for different things and typed the wrong one.

"matchStrings": ["grpc/python:(?<currentValue>.*?\\s"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't we missed ) after the question mark?

"matchStrings": ["grpc/python:(?<currentValue>.*?)\\s"],

for the deps below too

"datasourceTemplate": "github-tags",
"depNameTemplate": "grpc/grpc"
},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
"matchStrings": ["protocolbuffers/python:(?<currentValue>.*?\\s"],
"datasourceTemplate": "github-tags",
"depNameTemplate": "protocolbuffers/protobuf"
},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
"matchStrings": ["protocolbuffers/go:(?<currentValue>.*?\\s"],
"datasourceTemplate": "github-tags",
"depNameTemplate": "protocolbuffers/protobuf-go"
},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
"matchStrings": ["grpc-ecosystem/gateway:(?<currentValue>.*?\\s"],
"datasourceTemplate": "github-tags",
"depNameTemplate": "grpc-ecosystem/grpc-gateway"
}
]
}
8 changes: 4 additions & 4 deletions buf.gen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
version: v1
plugins:
- plugin: go
- plugin: buf.build/protocolbuffers/go:v1.31.0
out: gen/go
opt: paths=source_relative
- plugin: go-grpc
- plugin: buf.build/grpc/go:v1.3.0
out: gen/go
opt: paths=source_relative
- name: grpc-gateway
- name: buf.build/grpc-ecosystem/gateway:v2.19.0
out: ./gen/go
opt: paths=source_relative
- plugin: buf.build/grpc/python:v1.59.2
out: gen/python
- plugin: buf.build/protocolbuffers/python
- plugin: buf.build/protocolbuffers/python:v25.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pin and update in renovate go, go-grpc, grpc-gateway versions?

Copy link
Contributor Author

@sandersms sandersms Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets go ahead and do that as it will allow for controlled and tracked changes based on tool updates.

Pinning the different versions is directly doable from the buf.build plugin's. The renovate update for the go and grpc-gateway version can be mapped to the github-tags. The go-grpc is a managed function within the github grpc/grpc-go repository and can't be tracked by the github-tags. Will have to determine a method for renovate to track that specific function, perhaps from the google.golang.org site. I will open that as a separate issue to track and put the changes in for the pinning and two repo's for renovate operation.

out: gen/python


Loading