Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update renovate for buf gen package versions #435

Merged
merged 5 commits into from
Jan 24, 2024

Conversation

sandersms
Copy link
Contributor

Set the buf gen python packages for protobuf file generation and add package version checking to renovate to automate the detection and update of the packages for buf support.

Signed-off-by: Mark Sanders <marksanders194@gmail.com>
@sandersms sandersms marked this pull request as ready for review January 17, 2024 19:28
@sandersms sandersms requested a review from a team as a code owner January 17, 2024 19:28
@sandersms sandersms linked an issue Jan 17, 2024 that may be closed by this pull request
@@ -11,7 +11,7 @@ plugins:
opt: paths=source_relative
- plugin: buf.build/grpc/python:v1.59.2
out: gen/python
- plugin: buf.build/protocolbuffers/python
- plugin: buf.build/protocolbuffers/python:v25.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also pin and update in renovate go, go-grpc, grpc-gateway versions?

Copy link
Contributor Author

@sandersms sandersms Jan 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, lets go ahead and do that as it will allow for controlled and tracked changes based on tool updates.

Pinning the different versions is directly doable from the buf.build plugin's. The renovate update for the go and grpc-gateway version can be mapped to the github-tags. The go-grpc is a managed function within the github grpc/grpc-go repository and can't be tracked by the github-tags. Will have to determine a method for renovate to track that specific function, perhaps from the google.golang.org site. I will open that as a separate issue to track and put the changes in for the pinning and two repo's for renovate operation.

Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but noticed some issues

@@ -25,6 +25,30 @@
"matchStrings": ["google-api-linter:(?<currentValue>.*?)\\s"],
"datasourceTemplate": "docker",
"depNameTemplate": "ghcr.io/docker-multiarch/google-api-linter"
},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those deps are described in buf.gen.yaml file, not buf.work.yaml
below as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh - yeah - I was looking at both files for different things and typed the wrong one.

},
{
"fileMatch": ["(^|\\/)buf.work.yaml"],
"matchStrings": ["grpc/python:(?<currentValue>.*?\\s"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't we missed ) after the question mark?

"matchStrings": ["grpc/python:(?<currentValue>.*?)\\s"],

for the deps below too

Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artek-koltun artek-koltun merged commit 352c33e into opiproject:main Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add versions to the generator functions in buf.gen.yaml
2 participants