-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update renovate for buf gen package versions #435
Conversation
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
@@ -11,7 +11,7 @@ plugins: | |||
opt: paths=source_relative | |||
- plugin: buf.build/grpc/python:v1.59.2 | |||
out: gen/python | |||
- plugin: buf.build/protocolbuffers/python | |||
- plugin: buf.build/protocolbuffers/python:v25.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also pin and update in renovate go
, go-grpc
, grpc-gateway
versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets go ahead and do that as it will allow for controlled and tracked changes based on tool updates.
Pinning the different versions is directly doable from the buf.build plugin's. The renovate update for the go and grpc-gateway version can be mapped to the github-tags. The go-grpc is a managed function within the github grpc/grpc-go repository and can't be tracked by the github-tags. Will have to determine a method for renovate to track that specific function, perhaps from the google.golang.org site. I will open that as a separate issue to track and put the changes in for the pinning and two repo's for renovate operation.
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but noticed some issues
.github/renovate.json
Outdated
@@ -25,6 +25,30 @@ | |||
"matchStrings": ["google-api-linter:(?<currentValue>.*?)\\s"], | |||
"datasourceTemplate": "docker", | |||
"depNameTemplate": "ghcr.io/docker-multiarch/google-api-linter" | |||
}, | |||
{ | |||
"fileMatch": ["(^|\\/)buf.work.yaml"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those deps are described in buf.gen.yaml
file, not buf.work.yaml
below as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh - yeah - I was looking at both files for different things and typed the wrong one.
.github/renovate.json
Outdated
}, | ||
{ | ||
"fileMatch": ["(^|\\/)buf.work.yaml"], | ||
"matchStrings": ["grpc/python:(?<currentValue>.*?\\s"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't we missed )
after the question mark?
"matchStrings": ["grpc/python:(?<currentValue>.*?)\\s"],
for the deps below too
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
a8089f2
to
fce6708
Compare
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Set the buf gen python packages for protobuf file generation and add package version checking to renovate to automate the detection and update of the packages for buf support.