refactor(common): split inventory from common #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
|
@sandersms please clone security-skip.yml and security.yml for inventory |
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
|
@sandersms this line needs fix |
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
glimchb
added
the
Merge Candidate
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
|
Found an incorrect resource reference and made the fix prior to approval/merge. |
This was referenced Oct 12, 2023
artek-koltun
approved these changes
Oct 16, 2023
glimchb
requested changes
Oct 16, 2023
Signed-off-by: Mark Sanders <marksanders194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the inventory from the common folder to allow for adding capabilities along with the inventory. This also solves the multiple folder issue that was being reported by the inventory file being in the common folder and directed toward an inventory service capability.