Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage]: enable BUF linter and compiler #329

Closed
glimchb opened this issue Aug 14, 2023 · 1 comment · Fixed by #411, #413, #386 or #404
Closed

[storage]: enable BUF linter and compiler #329

glimchb opened this issue Aug 14, 2023 · 1 comment · Fixed by #411, #413, #386 or #404
Assignees

Comments

@glimchb
Copy link
Member

glimchb commented Aug 14, 2023

see https://buf.build/docs/lint/usage#5.-docker

and 0729d7f :

jobs:
  lint-protos:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: bufbuild/buf-setup-action@v1
      - uses: bufbuild/buf-lint-action@v1
@glimchb glimchb changed the title enable BUF linter enable BUF linter Aug 14, 2023
@glimchb glimchb changed the title enable BUF linter enable BUF linter and compiler Sep 12, 2023
@glimchb
Copy link
Member Author

glimchb commented Oct 23, 2023

storage fails on

docker run --rm -it -v /etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem:/etc/ssl/certs/ca-certificates.crt --volume "$(pwd):/workspace" --workdir /workspace bufbuild/buf lint
storage/v1alpha1/backend_aio.proto:21:8:opicommon.proto: does not exist

if

diff --git a/buf.work.yaml b/buf.work.yaml
index 7ddb5da..80d77b7 100644
--- a/buf.work.yaml
+++ b/buf.work.yaml
@@ -3,7 +3,7 @@ directories:
 - common
 - inventory
 - security
-#  - storage
+- storage
 #  - network/opinetcommon
 #  - network/cloud
 #  - network/evpn-gw
diff --git a/storage/buf.yaml b/storage/buf.yaml
index 68e0534..058452d 100644
--- a/storage/buf.yaml
+++ b/storage/buf.yaml
@@ -1,4 +1,4 @@
-version: v1beta1
+version: v1
 name: buf.build/opiproject/storage
 deps:
 - buf.build/googleapis/googleapis

with this change

diff --git a/storage/v1alpha1/backend_aio.proto b/storage/v1alpha1/backend_aio.proto
index 28beafa..afe1da8 100644
--- a/storage/v1alpha1/backend_aio.proto
+++ b/storage/v1alpha1/backend_aio.proto
@@ -18,7 +18,7 @@ import "google/api/annotations.proto";
 import "google/api/field_behavior.proto";
 import "google/protobuf/field_mask.proto";

-import "opicommon.proto";
+import "v1alpha1/opicommon.proto";
 import "uuid.proto";

 // Back End (network-facing) APIs. This service is for AIO generic kernel block device.
(END)

all seems a bit better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment