Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto: add python and cpp #139

Merged
merged 2 commits into from
Sep 29, 2022
Merged

proto: add python and cpp #139

merged 2 commits into from
Sep 29, 2022

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Sep 29, 2022

  • remove auto-gen files
  • proto: add python and cpp

@glimchb
remove auto-gen files
0c41bc0 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
@glimchb
proto: add python and cpp
ee74931 
Signed-off-by: Boris Glimcher <Boris.Glimcher@emc.com>
PWAlessi
PWAlessi approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@PWAlessi PWAlessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think it makes sense to remove the .pb.go files.

mestery
mestery approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@mestery mestery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

network/Makefile
@@ -5,5 +5,7 @@
all:
rm -rf ./proto/{autogen.md,*.pb.go}
docker run -v "${PWD}":/defs namely/protoc-all:1.47_2 --lint -d proto -l go -o ./proto/ --go-source-relative
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in one go with commas between generated versions? I'm fine either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted separate commands to maybe use separate folders for generated files later on...
will dig into documentation a bit...

@glimchb glimchb merged commit 95b2b4b into opiproject:main Sep 29, 2022
This was referenced Sep 29, 2022
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mestery mestery mestery approved these changes

@PWAlessi PWAlessi PWAlessi approved these changes

@seroyer seroyer Awaiting requested review from seroyer

@sandersms sandersms Awaiting requested review from sandersms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glimchb @mestery @PWAlessi