-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add or remove auto-gen files #142
Comments
FYI, Google just provides the .proto files for their APIs (see https://github.com/googleapis/googleapis/tree/master/google). Directory structure typically ./service/v1/*.proto (ex. google ai platform https://github.com/googleapis/googleapis/tree/master/google/cloud/aiplatform/v1) Should we move to this structure? I believe that we only want to provide the .proto files as they are the interface definitions. |
auto-gen files create a nuisance when merging, but helps avoid additional code generation by the users of the APIs. I would prefer keeping generated files and language bindings/packages so they can act as reference and also avoid burden on the users of the APIs (which would be inherently in a specific language). Of course developers have to deal with merge conflicts resolution on generated files, which can be handled easily (although unwanted) |
what we landing on now is separate repo for only generated files.... every time PR for proto is submitted, CI/CD github action will auto-create and commit generated files |
makes sense. thanks! good idea. |
see #139 vs #141
The text was updated successfully, but these errors were encountered: