Generate invalid zim file with invalid offsets in clusters. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgautierfr
added a commit
to openzim/libzim
that referenced
this pull request
Jun 10, 2024
Not that the test is correctly catching invalid offset only for nons variant. Current `validate` method is not checking the offsets in the cluster. Nons variant detect the invalid offset as `urlPtrList` is stored in the cluster and so we try to open it. Correct test will be added in next commit. Need PR openzim/zim-testing-suite#9
This was referenced Jun 10, 2024
veloman-yunkan
approved these changes
Jun 11, 2024
mgautierfr
force-pushed
the
wrong_cluster_offsets
branch
from
58deab9
to
db7dd24
Compare
|
Squashed and merged. |
mgautierfr
added a commit
to openzim/libzim
that referenced
this pull request
Jun 17, 2024
Not that the test is correctly catching invalid offset only for nons variant. Current `validate` method is not checking the offsets in the cluster. Nons variant detect the invalid offset as `titlePtrList` is stored in the cluster and so we try to open it (using `X/listing/titleOrdered/vX`) Correct test will be added in next commit. Need PR openzim/zim-testing-suite#9
kelson42
pushed a commit
to openzim/libzim
that referenced
this pull request
Jun 22, 2024
Not that the test is correctly catching invalid offset only for nons variant. Current `validate` method is not checking the offsets in the cluster. Nons variant detect the invalid offset as `titlePtrList` is stored in the cluster and so we try to open it (using `X/listing/titleOrdered/vX`) Correct test will be added in next commit. Need PR openzim/zim-testing-suite#9
kelson42
pushed a commit
to openzim/libzim
that referenced
this pull request
Jun 22, 2024
Not that the test is correctly catching invalid offset only for nons variant. Current `validate` method is not checking the offsets in the cluster. Nons variant detect the invalid offset as `titlePtrList` is stored in the cluster and so we try to open it (using `X/listing/titleOrdered/vX`) Correct test will be added in next commit. Need PR openzim/zim-testing-suite#9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for openzim/libzim#895