Correctly test invalid offsets in clusters. #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veloman-yunkan
requested changes
Jun 11, 2024
mgautierfr
force-pushed
the
fix_crash_invalid_zim
branch
from
a5d1c2f
to
0888639
Compare
|
@mgautierfr Both macOS and Windows CI don't pass. |
mgautierfr
force-pushed
the
fix_crash_invalid_zim
branch
from
0888639
to
58a727b
Compare
|
I know. |
|
@mgautierfr What is the status here? Testing auite has been released, but the CI still fails... and acutally I wanted to release 9.2.2 this WE. |
kelson42
force-pushed
the
fix_crash_invalid_zim
branch
from
58a727b
to
b1c15dc
Compare
This test is to check that value parsed are consistent. This is not to catch a potential bug in our code. So we must throw a ZimFileFormatError in this case.
Not that the test is correctly catching invalid offset only for nons variant. Current `validate` method is not checking the offsets in the cluster. Nons variant detect the invalid offset as `titlePtrList` is stored in the cluster and so we try to open it (using `X/listing/titleOrdered/vX`) Correct test will be added in next commit. Need PR openzim/zim-testing-suite#9
kelson42
force-pushed
the
fix_crash_invalid_zim
branch
from
b1c15dc
to
338812a
Compare
kelson42
force-pushed
the
fix_crash_invalid_zim
branch
from
338812a
to
14fdd56
Compare
|
I have:
I will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offset test in the cluster is to check that value parsed are consistent.
This is not to catch a potential bug in our code.
So we must throw a ZimFileFormatError in this case.
Extend the
validatefunction to test this kind of corrupted offset.Need openzim/zim-testing-suite#9
Fix #893