Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements.txt: zimscraperlib>=2.0.0,<2.1.0 #172

Merged
merged 3 commits into from
Feb 7, 2023
Merged

requirements.txt: zimscraperlib>=2.0.0,<2.1.0 #172

merged 3 commits into from
Feb 7, 2023

Conversation

holta
Copy link
Contributor

@holta holta commented Feb 7, 2023

Thanks to @deldesir who quickly tested this with zimscraperlib 2.0.0

@rgaudin & @kelson42 is this what's needed?

@holta holta changed the title requirements.txt: zimscraperlib>=1.8.0,<2.0.0 requirements.txt: zimscraperlib>=1.8.0,<=2.0.0 Feb 7, 2023
rgaudin
rgaudin requested changes Feb 7, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to bump is to the version you want to use yet define a range to allow for its future minor versions to be used.
So it would be:

zimscraperlib>=2.0.0,<2.1.0

@holta holta changed the title requirements.txt: zimscraperlib>=1.8.0,<=2.0.0 requirements.txt: zimscraperlib>=2.0.0,<2.1.0 Feb 7, 2023
@holta
Copy link
Contributor Author

holta commented Feb 7, 2023

The idea is to bump is to the version you want to use yet define a range to allow for its future [PATCH] versions to be used.

I assume you mean PATCH versions rather than MINOR, per https://semver.org/#semantic-versioning-200

Done!

rgaudin
rgaudin approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin
Copy link
Member

rgaudin commented Feb 7, 2023

Yes, sorry 😉

@rgaudin rgaudin merged commit 0574bce into openzim:main Feb 7, 2023
@holta holta mentioned this pull request Feb 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holta @rgaudin