Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can zimscraperlib 2.0 be used? #171

Closed
holta opened this issue Feb 6, 2023 · 2 comments
Closed

Can zimscraperlib 2.0 be used? #171

holta opened this issue Feb 6, 2023 · 2 comments
Assignees
@rgaudin
Labels
enhancement good first issue
Milestone
2.2.0

Comments

@holta
Copy link
Contributor

holta commented Feb 6, 2023 •
edited
Loading

Thanks for zimscraperlib 2.0 released 2 months ago!

Question: Can we begin allowing this as part of youtube2zim ?

youtube/requirements.txt

Line 8 in 2897b6d

zimscraperlib>=1.8.0,<1.9

2022-11-08 background:

  • "Using zimscraperlib 1.8.0" c9938a6
@kelson42 kelson42 added this to the 2.2.0 milestone Feb 6, 2023
@rgaudin
Copy link
Member

rgaudin commented Feb 7, 2023

👍

@holta holta mentioned this issue Feb 7, 2023
Merged
@holta
Copy link
Contributor Author

holta commented Feb 7, 2023

Resolved by:

Thanks @rgaudin

@holta holta closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgaudin rgaudin

Labels
enhancement good first issue
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@rgaudin @kelson42 @holta