Ignore (wrong) webp mime-type from S3 #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
ignore-s3-web-mime-type
branch
from
d77291f
to
c31cd31
Compare
Codecov ReportBase: 69.58% // Head: 69.53% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
==========================================
- Coverage 69.58% 69.53% -0.06%
==========================================
Files 23 23
Lines 2581 2583 +2
Branches 589 590 +1
==========================================
Hits 1796 1796
- Misses 673 674 +1
- Partials 112 113 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1772
Root cause of the problem seems not a broken code but wrong values in the S3. Many PNG/JPG images have a mime-type of
image/webpin S3 which is wrong. I guess that during the developement of milestone1.12.0a regression has been introduced at some point and then fixed. But it was long enough there that test runs have polluted the bucket. With this fix it should work and after a bit, we could remove the patch from our source code because (most?) values should be fixed in the S3.