Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION] A large number of images are missing in the most recent Wikipedias #1772

Closed
Inbefortus opened this issue Feb 8, 2023 · 6 comments · Fixed by #1773
Closed
Assignees
Labels
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Feb 8, 2023

@uriesk I guess we have built a regression here... This confirms my first impression... but I don't have run any investigation so far.

@kelson42
Copy link
Collaborator

kelson42 commented Feb 8, 2023

Good news is that missing images are in the ZIM but, for example https://library.kiwix.org/content/wikipedia_en_top_maxi_2023-02/I/Chromosome.svg.png, but https://library.kiwix.org/content/wikipedia_en_top_maxi_2023-02/I/Chromosome.svg.png.webp is referenced.

@Inbefortus
Copy link
Author

Good news is that missing images are in the ZIM but, for example https://library.kiwix.org/content/wikipedia_en_top_maxi_2023-02/I/Chromosome.svg.png, but https://library.kiwix.org/content/wikipedia_en_top_maxi_2023-02/I/Chromosome.svg.png.webp is referenced.

This makes sense, as I was perplexed as to why the ZIM with so many "missing" images still remained larger than the previous one... This clarifies it. I'm relieved to hear it's not as severe!

@Jaifroid
Copy link
Collaborator

Jaifroid commented Feb 8, 2023

Confirmed, just removing the webp ending in dev tools allows the image to be loaded. Rather strange error, in particular that it has happened in some cases, but not in the vast majority of cases.

image

@kelson42 kelson42 added this to the 1.12.1 milestone Feb 8, 2023
@kelson42 kelson42 changed the title A large number of images are missing in the most recent Wikipedias [REGRESSION] A large number of images are missing in the most recent Wikipedias Feb 8, 2023
@Inbefortus
Copy link
Author

@kelson42 Your fix was effective 👍

Screenshot_20230209-150754_Samsung Internet Beta

@kelson42
Copy link
Collaborator

kelson42 commented Feb 9, 2023

We will do a patch release soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants