alternative retry strategy for downloading files #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.11% // Head: 69.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
- Coverage 69.11% 69.03% -0.08%
==========================================
Files 23 23
Lines 2477 2487 +10
Branches 588 591 +3
==========================================
+ Hits 1712 1717 +5
- Misses 651 656 +5
Partials 114 114
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
looks good |
|
@uriesk Thx, will have a look this WE and merge if OK in priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't immediately retry failed file requests again.
Instead use the already existing filesToRetryXPath store multiple times to retry after the rest is done.
fixes #1750