Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teach zdb about DMU_OT_ERROR_LOG objects #14442

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Teach zdb about DMU_OT_ERROR_LOG objects #14442

merged 1 commit into from
Feb 2, 2023

Conversation

gamanakis
Copy link
Contributor

@gamanakis gamanakis commented Jan 27, 2023 •
edited
Loading

Motivation and Context

Closes #14434

Description

With the persistent error log feature we need to account for spa_errlog_{scrub, last} containing mappings to other error log objects, which need to be marked as in-use as well.

How Has This Been Tested?

./scripts/zloop.sh

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gamanakis gamanakis marked this pull request as ready for review January 28, 2023 19:12
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 30, 2023
behlendorf
behlendorf approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out!

cmd/zdb/zdb.c Outdated Show resolved Hide resolved
@behlendorf behlendorf requested a review from ahrens January 30, 2023 20:25
ahrens
ahrens reviewed Jan 30, 2023
View reviewed changes
cmd/zdb/zdb.c Outdated Show resolved Hide resolved
cmd/zdb/zdb.c Outdated Show resolved Hide resolved
@gamanakis
Teach zdb about DMU_OT_ERROR_LOG objects
296cdce 
With the persistent error log feature we need to account for
spa_errlog_{scrub, last} containing mappings to other error log objects,
which need to be marked as in-use as well.

Signed-off-by: George Amanakis <gamanakis@gmail.com>
@gamanakis
Copy link
Contributor Author

296cdce: implemented all suggestions, thank you!

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 30, 2023
@behlendorf behlendorf merged commit ac2038a into openzfs:master Feb 2, 2023
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 3, 2023
@gamanakis @lundman
Teach zdb about DMU_OT_ERROR_LOG objects
42411f7 
With the persistent error log feature we need to account for
spa_errlog_{scrub, last} containing mappings to other error log objects,
which need to be marked as in-use as well.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#14442 
Closes openzfs#14434
@behlendorf behlendorf mentioned this pull request Mar 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrens ahrens ahrens approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zloop fails with zdb: leaked MOS object (persistent error log)
3 participants
@gamanakis @behlendorf @ahrens