Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ztest: MOS leaks #14585

Closed
ryao opened this issue Mar 6, 2023 · 7 comments · Fixed by #14592
Closed

ztest: MOS leaks #14585

ryao opened this issue Mar 6, 2023 · 7 comments · Fixed by #14592
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Type: Defect Incorrect behavior (e.g. crash, hang)

Comments

@ryao
Copy link
Contributor

ryao commented Mar 6, 2023

Some of the zloop runs on recent commits merged to master show MOS leaks.

MOS object 179 (persistent error log) leaked

https://github.com/openzfs/zfs/actions/runs/4308081564

MOS object 468 (persistent error log) leaked
MOS object 469 (persistent error log) leaked
MOS object 470 (persistent error log) leaked
MOS object 471 (persistent error log) leaked
MOS object 472 (persistent error log) leaked
MOS object 473 (persistent error log) leaked
MOS object 474 (persistent error log) leaked
MOS object 475 (persistent error log) leaked

https://github.com/openzfs/zfs/actions/runs/4287500668
@ryao ryao added Type: Defect Incorrect behavior (e.g. crash, hang) Component: Test Suite Indicates an issue with the test framework or a test case labels Mar 6, 2023
@behlendorf
Copy link
Contributor

Was this issue not resolved by #14442 (commit ac2038a)?

@ryao
Copy link
Contributor Author

ryao commented Mar 6, 2023

Unfortunately, no. That commit was merged a month ago and these test failures happened last week.

@ryao
Copy link
Contributor Author

ryao commented Mar 6, 2023

@gamanakis It looks like the patch you wrote to address this did not fix the issue.

@ryao
Copy link
Contributor Author

ryao commented Mar 6, 2023

@ahrens Since you filed #14434, I am pinging you too, since the issue seems to still be unresolved.

@gamanakis
Copy link
Contributor

I think there is a typo in that commit. Let me take a look.

@gamanakis gamanakis mentioned this issue Mar 7, 2023
Merged
13 tasks
@gamanakis
Copy link
Contributor

@ryao could you give #14592 a try?

@ryao
Copy link
Contributor Author

ryao commented Mar 7, 2023

@ryao could you give #14592 a try?

This was detected by the github workflow on commits merged to master. I spotted it when looking at the reports. I do not currently have the ability to reproduce it myself.

behlendorf pushed a commit that referenced this issue Mar 7, 2023
@gamanakis
Fix a typo in ac2038a
12a240a 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: George Amanakis <gamanakis@gmail.com> 
Closes #14585
Closes #14592
mcmilk pushed a commit to mcmilk/zfs that referenced this issue Mar 13, 2023
@gamanakis @mcmilk
Fix a typo in ac2038a
97056e6 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: George Amanakis <gamanakis@gmail.com> 
Closes openzfs#14585
Closes openzfs#14592
lundman pushed a commit to openzfsonwindows/openzfs that referenced this issue Mar 16, 2023
@gamanakis @lundman
Fix a typo in ac2038a
1573da1 
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: George Amanakis <gamanakis@gmail.com> 
Closes openzfs#14585
Closes openzfs#14592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Type: Defect Incorrect behavior (e.g. crash, hang)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a typo in ac2038a gamanakis/zfs
3 participants
@behlendorf @ryao @gamanakis