Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore dirty dnode detection logic #12745

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Restore dirty dnode detection logic #12745

merged 1 commit into from
Nov 11, 2021

Conversation

behlendorf
Copy link
Contributor

Motivation and Context

Follow up for a regression introduced by the fix for issue #11900.

Description

In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link. Relying
on the dirty record has not be reliable, switch back to the previous
method.

How Has This Been Tested?

Requires additional testing to confirm it resolved all of the issues reported.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@behlendorf
Restore dirty dnode detection logic
2fee5a0 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Nov 10, 2021
@behlendorf behlendorf mentioned this pull request Nov 10, 2021
Closed
@behlendorf behlendorf merged commit c23803b into openzfs:master Nov 11, 2021
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 11, 2021
@behlendorf @tonyhutter
Restore dirty dnode detection logic
595e199 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#11900 
Closes openzfs#12745
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 11, 2021
@behlendorf @tonyhutter
Restore dirty dnode detection logic
d7e640c 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#11900 
Closes openzfs#12745
@rincebrain rincebrain mentioned this pull request Nov 11, 2021
Closed
13 tasks
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@behlendorf @tonyhutter
Restore dirty dnode detection logic
e3a180f 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#11900 
Closes openzfs#12745
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 13, 2021
@behlendorf @tonyhutter
Restore dirty dnode detection logic
33fa398 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#11900 
Closes openzfs#12745
@rincebrain rincebrain mentioned this pull request Apr 15, 2022
Closed
ofaaland pushed a commit to LLNL/zfs that referenced this pull request Mar 9, 2023
@behlendorf @ofaaland
Restore dirty dnode detection logic
b36c5d1 
In addition to flushing memory mapped regions when checking holes,
commit de198f2 modified the dirty dnode detection logic to check
the dn->dn_dirty_records instead of the dn->dn_dirty_link.  Relying
on the dirty record has not be reliable, switch back to the previous
method.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue openzfs#11900
Closes openzfs#12745
@rincebrain rincebrain mentioned this pull request Mar 9, 2023
Open
@pittagurneyi pittagurneyi mentioned this pull request Nov 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mmaybee mmaybee

Labels
Status: Code Review Needed Ready for review and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@behlendorf @mmaybee