Detect new wasm features #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queengooborg
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
The name mapping was a decision made in #452, and since the author's an expert when it comes to WebAssembly, I figured there was a good reason to do so -- perhaps it was to synchronize with MDN page structure. I also believe that the new names are more self-explanatory.
This is LGTM though!
|
Ah, thanks for the context! I don't see mdn_urls for these features. Anyway, I don't think we have to change this. The mapping works. The important part was to get to know about entirely new wasm features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the wasm collection is currently set up will not detect new wasm features. This PR gets the list of wasm features from the wasm-feature-detect package so the collector can find new wasm features from there.
Not sure why it was decided to not use the same keys from the wasm-feature-detect package in BCD. That would have been cleaner... I'm mapping the existing ones now.