-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WebAssembly features #452
Conversation
Thank you for working on this, @MendyBerger! This is looking quite wonderful so far! There are a couple of things that we should do to ensure that the collector will still run in older browser versions:
(If you'd like, I'd be more than happy to continue the development on this and get it ready to merge and deploy!) |
If you could easily do those things, please do. Otherwise, I'll take another look when I have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just made some changes to get this all ready to deploy! I've just got one question for you in regards to formatting wasm.json
, otherwise this looks great!
"BigInt-to-i64-integration": { | ||
"wfd-key": "bigInt" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that we should just simplify this to be "bcd-key": "wfd-key"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong preference. I did it this way so that in the future, we can add more configuration fields, but that might not be necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured that was the case, but I wasn't sure if you had any configuration options in mind -- I'll leave the format as-is just in case!
@queengooborg how long should it take until these results show up in caniuse.com? |
I can't say how long it would take for CanIUse to obtain them because it's a third party service, but for BCD, I'm hoping to get them added as soon as the new collector version is released. It may be a bit because I'm planning to increase category coverage and have a few other updates I wish to make, but once it's out I'll get a PR going to add this new category into BCD! |
Resolves mdn/browser-compat-data/issues/5796
Thanks @queengooborg for the new structure, it's a lot easier to make sense of the repo now.
Basic structure:
Added the
wasm-feature-detect
library, andtestWasmFeature
to the globalbcd
object.testWasmFeature
just callswasm-feature-detect
.All the tests are in
custom/wasm.json
, where they have a readable name as the key, and thewasm-feature-detect
name as thewfd-key
value.