feat: add dynamic suite and signing provider #949
Conversation
Signed-off-by: Timo Glastra <timo@animo.id>
TimoGlastra
added
modularization
Signed-off-by: Timo Glastra <timo@animo.id>
| export interface SigningProvider { | ||
| readonly keyType: KeyType | ||
|
|
||
| createKey(options: CreateKeyOptions): Promise<KeyPair> |
There was a problem hiding this comment.
| createKey(options: CreateKeyOptions): Promise<KeyPair> | |
| createKeyPair(options: CreateKeyPairOptions): Promise<KeyPair> |
For createKey I would expect a symmetric key.
|
|
||
| const LinkedDataSignature = suites.LinkedDataSignature | ||
|
|
||
| export const SignatureSuiteToken = Symbol('SignatureSuiteToken') | ||
| export interface SuiteInfo { | ||
| suiteClass: typeof LinkedDataSignature |
There was a problem hiding this comment.
I would assume this is correct, but if is supposed to be generic between, for now, ed25519 and BBS+ then the LinkedDataSignature is not really a good name I think.
There was a problem hiding this comment.
I think the bbs suites also extend linked data signature.
There was a problem hiding this comment.
Nope it extends LinkedDataProof, and LinkedDataSignature also extends LinkedDataProof.
@karimStekelenburg any reason you used LinkedDataSignature instead of LinkedDataProof?
There was a problem hiding this comment.
Hmm not sure tbh. Probably by accident
Signed-off-by: Timo Glastra <timo@animo.id>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #949 +/- ##
=============================================
- Coverage 87.09% 85.20% -1.90%
=============================================
Files 536 539 +3
Lines 13050 13086 +36
Branches 2244 2244
=============================================
- Hits 11366 11150 -216
- Misses 1588 1805 +217
- Partials 96 131 +35
Continue to review full report at Codecov.
|
Signed-off-by: Timo Glastra <timo@animo.id>
|
Merging as only failing test is the BBS test. |
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id> Signed-off-by: Ariel Gentile <gentilester@gmail.com>
Extends the
SignatureSuiteRegistryand adds aSigningProviderRegistrythat allows to dynamically register signers for key types and signature suites. This is needed in preparation of #948, so we can extract the bbs signing provider and signature suites to it's own package.Extracting into a separate package will be done in a separate PR.
BbsService has been moved into the generic
SigningProviderinterface. I've removed support for Bls12381g1 keys for now as they're not really used for anything. It will be easy to add back in.