Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract bbs dependencies into @aries-framework/bbs-signatures packages #948

Closed
TimoGlastra opened this issue Jul 14, 2022 · 0 comments · Fixed by #1035
Closed

Extract bbs dependencies into @aries-framework/bbs-signatures packages #948

TimoGlastra opened this issue Jul 14, 2022 · 0 comments · Fixed by #1035
Assignees
@TimoGlastra
Labels
0.3.0 Changes for the 0.3.0 release modularization Tasks related to modularization of the framework
Milestone
v0.3.0

Comments

@TimoGlastra
Copy link
Contributor

See https://hackmd.io/6eXZcMhdQR-QCNPMFYTvuA?view#W3C-Credentials

All code that uses the mattr bbs libraries should be extracted to the @aries-framework/bbs-signatures which can then be dynamically added if bbs support is desired. This way you're not forced to add yet another native binary to your mobile app (this is where it counts the most).
@TimoGlastra TimoGlastra added modularization Tasks related to modularization of the framework 0.3.0 Changes for the 0.3.0 release labels Jul 14, 2022
@TimoGlastra TimoGlastra added this to the v0.3.0 milestone Jul 14, 2022
@TimoGlastra TimoGlastra mentioned this issue Jul 14, 2022
Merged
@TimoGlastra TimoGlastra self-assigned this Sep 21, 2022
@TimoGlastra TimoGlastra mentioned this issue Sep 22, 2022
Merged
@TimoGlastra TimoGlastra linked a pull request Sep 22, 2022 that will close this issue
feat(bbs): extract bbs logic into separate module #1035
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimoGlastra TimoGlastra

Labels
0.3.0 Changes for the 0.3.0 release modularization Tasks related to modularization of the framework
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat(bbs): extract bbs logic into separate module TimoGlastra/aries-framework-javascript
1 participant
@TimoGlastra