Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Aligned ReduceL1 behavior #20559 #25909

Merged

Conversation

RitikaxShakya
Copy link
Contributor

@RitikaxShakya RitikaxShakya commented Aug 5, 2024

Details:

-I've aligned the ReduceL1 operation with opset 11, 13, and 18. created test models, and added them inside onnx_import.in.cpp.

Tickets:

@RitikaxShakya RitikaxShakya requested a review from a team as a code owner August 5, 2024 12:57
@github-actions github-actions bot added the category: ONNX FE OpenVINO ONNX FrontEnd label Aug 5, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label Aug 5, 2024
@RitikaxShakya
Copy link
Contributor Author

RitikaxShakya commented Aug 5, 2024

@gkrivor I have few question regarding

  1. Where is reduce.hpp file?
  2. There aren't any registered ops in ops_bridge.cpp so do i still need to register there ?

@gkrivor
Copy link
Contributor

gkrivor commented Aug 7, 2024

@RitikaxShakya you are correct. I moved registration near translator's definition.

@RitikaxShakya
Copy link
Contributor Author

@RitikaxShakya you are correct. I moved registration near translator's definition.

Oh okay, let me know if there's anything i have to do from my side. Thank you!

@gkrivor
Copy link
Contributor

gkrivor commented Aug 7, 2024

build_jenkins

@gkrivor
Copy link
Contributor

gkrivor commented Aug 8, 2024

build_jenkins

@gkrivor
Copy link
Contributor

gkrivor commented Aug 8, 2024

build_jenkins

@gkrivor gkrivor added this pull request to the merge queue Aug 9, 2024
@gkrivor gkrivor added this to the 2024.4 milestone Aug 9, 2024
Merged via the queue into openvinotoolkit:master with commit cb9ee02 Aug 9, 2024
137 checks passed
mory91 pushed a commit to mory91/openvino that referenced this pull request Aug 13, 2024
…it#25909)

### Details:
-I've aligned the ReduceL1 operation with opset 11, 13, and 18. created
test models, and added them inside onnx_import.in.cpp.

### Tickets:
 - **openvinotoolkit#20559

---------

Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd ExternalPR External contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants