-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Aligned ReduceL1 behavior #20559 #23758
[ONNX] Aligned ReduceL1 behavior #20559 #23758
Conversation
@gkrivor @p-wysocki Please take a look at this PR. Thank You! |
540383e
to
fa94927
Compare
build_jenkins |
@gkrivor Hello! If there is anything i need to do from my end, please let me know. Thank you! |
This PR will be closed in a week because of 2 weeks of no activity. |
@gkrivor Hello! Please let me know If there is anything i need to do from my end. Thank you! |
we are willing to merge it, could you please resolve conflicts? |
Solved conflicts |
build_jenkins |
This PR will be closed in a week because of 2 weeks of no activity. |
build_jenkins |
@gkrivor could you take a look, please? |
This PR will be closed in a week because of 2 weeks of no activity. |
hey @RitikaxShakya |
Okay, i will try finishing it this week |
thanks! |
@RitikaxShakya could you rebase your change? There are several changes in the code which should be solved. |
Hi @RitikaxShakya, tell me please if you have any issues with rebasing I'll help. |
2570363
to
c664ca7
Compare
Hi @RitikaxShakya , any issues? |
Yes, i tried rebasing and solve conflicts but it kinda messed up by showing commits that i didn't make, i tried resetting but its also not working. but I have my changes saves so i am thinking to make new PR, is that alright with you ? I would take me a day. |
It is because of merging a master branch. You can try to make a rebasing your branch locally to a current master. It should cleanup common changes and you will see only your changes. |
Oh okay, i tried this as well but it doesn't cleanup but i will try again, if it works cool, if not then will open a new pr. Thank you! |
Hey I opened new PR Here, I have few questions, i have asked them in new PR. |
Details:
-I've aligned the ReduceL1 operation with opset 11, 13, and 18. I've registered the function inside the ops_bridge.cpp, created test models, and added them inside onnx_import.in.cpp.
Tickets: