Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Aligned ReduceL1 behavior #20559 #23758

Conversation

RitikaxShakya
Copy link
Contributor

Details:

-I've aligned the ReduceL1 operation with opset 11, 13, and 18. I've registered the function inside the ops_bridge.cpp, created test models, and added them inside onnx_import.in.cpp.

Tickets:

@RitikaxShakya
Copy link
Contributor Author

@gkrivor @p-wysocki Please take a look at this PR. Thank You!

@gkrivor gkrivor force-pushed the Align_reducel1_behavior_#20559 branch from 540383e to fa94927 Compare April 2, 2024 08:31
@gkrivor
Copy link
Contributor

gkrivor commented Apr 2, 2024

build_jenkins

@gkrivor gkrivor changed the title Align reducel1 behavior #20559 [ONNX] Aligned ReduceL1 behavior #20559 Apr 3, 2024
@RitikaxShakya
Copy link
Contributor Author

@gkrivor Hello! If there is anything i need to do from my end, please let me know. Thank you!

@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label May 20, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@RitikaxShakya
Copy link
Contributor Author

This PR will be closed in a week because of 2 weeks of no activity.

@gkrivor Hello! Please let me know If there is anything i need to do from my end. Thank you!

@github-actions github-actions bot removed the Stale label Jun 6, 2024
@mlukasze
Copy link
Contributor

we are willing to merge it, could you please resolve conflicts?

@RitikaxShakya
Copy link
Contributor Author

we are willing to merge it, could you please resolve conflicts?

Solved conflicts

@mlukasze
Copy link
Contributor

build_jenkins

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 4, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Jul 4, 2024

build_jenkins

@mlukasze
Copy link
Contributor

mlukasze commented Jul 4, 2024

@gkrivor could you take a look, please?

@github-actions github-actions bot removed the Stale label Jul 5, 2024
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 19, 2024
@mlukasze
Copy link
Contributor

hey @RitikaxShakya
could you please resolve conflicts? we will review it very soon
thanks and sorry for the delay, it's on us :(

@github-actions github-actions bot removed the Stale label Jul 20, 2024
@RitikaxShakya
Copy link
Contributor Author

hey @RitikaxShakya could you please resolve conflicts? we will review it very soon thanks and sorry for the delay, it's on us :(

Okay, i will try finishing it this week

@mlukasze
Copy link
Contributor

thanks!

@gkrivor
Copy link
Contributor

gkrivor commented Jul 26, 2024

@RitikaxShakya could you rebase your change? There are several changes in the code which should be solved.

@gkrivor
Copy link
Contributor

gkrivor commented Aug 2, 2024

Hi @RitikaxShakya, tell me please if you have any issues with rebasing I'll help.

@RitikaxShakya RitikaxShakya deleted the Align_reducel1_behavior_#20559 branch August 4, 2024 12:23
@RitikaxShakya RitikaxShakya restored the Align_reducel1_behavior_#20559 branch August 4, 2024 12:23
@gkrivor
Copy link
Contributor

gkrivor commented Aug 5, 2024

Hi @RitikaxShakya , any issues?

@RitikaxShakya
Copy link
Contributor Author

Hi @RitikaxShakya , any issues?

Yes, i tried rebasing and solve conflicts but it kinda messed up by showing commits that i didn't make, i tried resetting but its also not working. but I have my changes saves so i am thinking to make new PR, is that alright with you ? I would take me a day.

@gkrivor
Copy link
Contributor

gkrivor commented Aug 5, 2024

It is because of merging a master branch. You can try to make a rebasing your branch locally to a current master. It should cleanup common changes and you will see only your changes.
I'm ok with new PR too :)

@RitikaxShakya
Copy link
Contributor Author

It is because of merging a master branch. You can try to make a rebasing your branch locally to a current master. It should cleanup common changes and you will see only your changes. I'm ok with new PR too :)

Oh okay, i tried this as well but it doesn't cleanup but i will try again, if it works cool, if not then will open a new pr. Thank you!

@RitikaxShakya
Copy link
Contributor Author

It is because of merging a master branch. You can try to make a rebasing your branch locally to a current master. It should cleanup common changes and you will see only your changes. I'm ok with new PR too :)

Hey I opened new PR Here, I have few questions, i have asked them in new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: ONNX FE OpenVINO ONNX FrontEnd ExternalPR External contributor
Projects
None yet
4 participants