Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec][Internal][Op] Specification for RMS internal op #24564

Merged
merged 5 commits into from
May 21, 2024
Merged

[Spec][Internal][Op] Specification for RMS internal op #24564

merged 5 commits into from
May 21, 2024

Conversation

mitruska
Copy link
Contributor

@mitruska mitruska commented May 17, 2024 •
edited
Loading

Details:

  • Dev documentation for the existing internal::RMS op
    (specified as is without any additional features, to be developed and updated if needed)
  • RMS was created initially as a custom gpu RMS operation, and it's going to be moved to op::internal::RMS to be available for common transformations
  • Similar approach as it was done for AUGRUCell/AUGRUSeqence, so the place for such documents has been already agreed and it's not a part of the official web docs tree

Tickets:

  • 134914, dicsussion 129027

@github-actions github-actions bot added the category: docs OpenVINO documentation label May 17, 2024
@mitruska mitruska marked this pull request as ready for review May 17, 2024 08:36
@mitruska mitruska requested a review from a team as a code owner May 17, 2024 08:36
@mitruska mitruska requested review from akopytko, vladimir-paramuzov, andrew-k-park, a team, mmikolajcz and praasz and removed request for a team May 17, 2024 08:36
This was referenced May 17, 2024
Merged
Closed
@mitruska mitruska self-assigned this May 17, 2024
@mitruska mitruska mentioned this pull request May 17, 2024
Closed
@mitruska mitruska added this pull request to the merge queue May 21, 2024
Merged via the queue into openvinotoolkit:master with commit b71eab2 May 21, 2024
81 checks passed
@mitruska mitruska deleted the mitruska/rms_internal_spec branch May 21, 2024 15:43
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
@mitruska @michal-miotk @mlukasze
[Op][Internal] Reference implementation for internal::RMS op (#24556)
00856cd 
### Details:
- Reference implementation and ref tests for
[internal::RMS](https://github.com/openvinotoolkit/openvino/blob/70142121c1c632b6d710026150b0e6deb20b0e68/src/common/transformations/include/ov_ops/rms.hpp)
(moved from gpu custom ops) available for common transformations
 - Enable Accuracy tests for RMSFusion transformation
 
 The changes moving RMS from gpu to internal are from PR:
 -  #24539 (to be merged first)
 
 Internal RMS op docs:
- #24564

 ### Tickets:
 - Related to 136262

---------

Co-authored-by: michal-miotk <michal.miotk@intel.com>
Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmikolajcz mmikolajcz mmikolajcz approved these changes

@praasz praasz praasz approved these changes

@akopytko akopytko Awaiting requested review from akopytko akopytko is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

@vladimir-paramuzov vladimir-paramuzov Awaiting requested review from vladimir-paramuzov

@andrew-k-park andrew-k-park Awaiting requested review from andrew-k-park

Assignees

@mitruska mitruska

Labels
category: docs OpenVINO documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mitruska @mmikolajcz @praasz