[Op] Common RMS operation - corrected author #24539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before call to_shape
added rms transformations to common space deleted transformations fusion moved fusion tests deleted RMS op defined in gpu_plugin changed op name workgroupsize check in callback, changed opset name fixed formating fix code style -3rd attempt fix code style -4rd attempt moved transformation_callback check to begin of function, added check before call to_shape fixes in rms fusion
github-actions
bot
added
category: GPU
mitruska
approved these changes
May 16, 2024
| return std::make_shared<RMS>(new_args.at(0), | ||
| new_args.at(1), | ||
| m_epsilon); | ||
| return std::make_shared<RMS>(new_args.at(0), new_args.at(1), m_epsilon); |
There was a problem hiding this comment.
The output_type attribute should be provided to the cloned RMS op (but it was missed in the original file, so can be fixed separately):
Suggested change
| return std::make_shared<RMS>(new_args.at(0), new_args.at(1), m_epsilon); | |
| return std::make_shared<RMS>(new_args.at(0), new_args.at(1), m_epsilon, m_output_type); |
p-durandin
approved these changes
May 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 22, 2024
### Details: - Reference implementation and ref tests for [internal::RMS](https://github.com/openvinotoolkit/openvino/blob/70142121c1c632b6d710026150b0e6deb20b0e68/src/common/transformations/include/ov_ops/rms.hpp) (moved from gpu custom ops) available for common transformations - Enable Accuracy tests for RMSFusion transformation The changes moving RMS from gpu to internal are from PR: - #24539 (to be merged first) Internal RMS op docs: - #24564 ### Tickets: - Related to 136262 --------- Co-authored-by: michal-miotk <michal.miotk@intel.com> Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
-move RMS operation to common internal opset
-move RMS fusion transformation to common part
-based on #24057
Tickets:
138554