[ONNX] Reduce* refactoring #23429
Merged
[ONNX] Reduce* refactoring #23429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 13, 2024
Closed
gkrivor
force-pushed
the
onnx_reduce_ref
branch
from
f860fae
to
a60c525
Compare
rkazants
reviewed
Mar 14, 2024
Comment on lines
+93
to
+96
| const std::set<element::Type> supported_types_v1 = | ||
| {element::u32, element::u64, element::i32, element::i64, element::f16, element::f32, element::f64}; | ||
| const std::set<element::Type> supported_types_v2 = | ||
| {element::u32, element::u64, element::i32, element::i64, element::f16, element::f32, element::f64, element::bf16}; |
There was a problem hiding this comment.
I think we do need to check input types to Reduce operation. That is because we assume input model is originally consistent (it comes with correct input type) and our Reduce operation should work for all of this operations
There was a problem hiding this comment.
This way we can explore limitation in core part and request to extend on new types if needed.
Let us say if some type not supported by core (or plugin, etc.) is needed by some model, then we should insert Convert operation that is not good.
We should rather to avoid any limitations in our part, assume that input model is consistent, and encourage other components avoid limitations.
rkazants
approved these changes
Mar 14, 2024
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
### Details: - Refactored source code to be able co-work with others - Removed unnecessary comments - Added check for a wrong input type - Added tests for an exception for wrong input type ### Tickets: - 125493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: