-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Align behavior of ONNX Frontend operator ReduceMean-11, 13, 18 with original framework #23148
Conversation
Hi, I refactored reduce.cpp and reduce.hpp. I think it should be more simple to add a new functionality. Please, rebase after merge. |
Hi @gkrivor! I had a few questions: do we need to add opset 11 to reduce.hpp Thank You |
This PR will be closed in a week because of 2 weeks of no activity. |
Hi @gkrivor make changes today |
} | ||
opset_import { | ||
domain: "" | ||
version: 16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add a model for Opset-18. Please, take a look on reduce_max_18.prototxt as an example.
Major thing you should reflect - provide an "axes" as an input instead of an attribute
@rghvsh as you can see, your change is very important and fix a lot of failing tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import code LGTM, but the tests are missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test model has been added, but there is no unit test code for it, so it's not tested.
For each added model there should be corresponding test in openvino/src/frontends/onnx/tests/onnx_import.in.cpp.
Also please keep the names of the onnx test models files aligned (snake_case).
Example:
openvino/src/frontends/onnx/tests/onnx_import.in.cpp
Lines 1018 to 1019 in 59c54cb
OPENVINO_TEST(${BACKEND_NAME}, onnx_model_reduce_log_sum_18_axes_as_input) { | |
auto model = convert_model("reduce_log_sum_18_axes_as_input.onnx"); |
@rghvsh could you add some tests and remove test which are working after your changes (take a look on my previous comment)? |
@rghvsh any updates? |
build_jenkins |
build_jenkins |
build_jenkins |
build_jenkins |
build_jenkins |
… with original framework (openvinotoolkit#23148) ### Details: - Align behavior of ONNX Frontend operator ReduceMean-11, 13, 18 with original framework ### Tickets: - Closes openvinotoolkit#20556 --------- Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
… with original framework (openvinotoolkit#23148) ### Details: - Align behavior of ONNX Frontend operator ReduceMean-11, 13, 18 with original framework ### Tickets: - Closes openvinotoolkit#20556 --------- Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
… with original framework (openvinotoolkit#23148) ### Details: - Align behavior of ONNX Frontend operator ReduceMean-11, 13, 18 with original framework ### Tickets: - Closes openvinotoolkit#20556 --------- Co-authored-by: Georgy Krivoruchko <georgy.krivoruchko@intel.com>
Details:
Tickets:
CVS-143344, CVS-125493