Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-API. Common StreamSource. IFD-GAPI small refactoring. #2778

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

mpashchenkov
Copy link
Contributor

PR provides common stream_source class which is used for all G-API demos. Implementation is questionable (CMakeLists should have some standards, which i haven't followed. I hope review help me with this).
Also PR contains small refactoring for Interactive Face detection G-API demo:

  • Added parseSSD kernel;
  • Demo works with ImagesCapture OMZ common class instead of SetInput().

@mpashchenkov mpashchenkov added demo Issues with demo results, performance and etc. refactoring Refactor of anything labels Sep 23, 2021
@@ -4,15 +4,14 @@

#include <monitors/presenter.h>
#include <utils/args_helper.hpp>
#include <utils/slog.hpp>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slog is still used in this demo, it should be directly included.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And, it seems, I forgot to include it directly in the smart_classroom_demo_gapi, when modified it. Can you add it here also, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files have dependencies with slog.hpp, m b, because this works fine. This include is returned.

Copy link
Contributor Author

@mpashchenkov mpashchenkov Sep 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

face_inference_results.hpp contains this file for gaze_estimation
and
custom_kernels.hpp for smart_classroom

Copy link
Contributor Author

@mpashchenkov mpashchenkov Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivikhrev Could the thread will be resolved?

@mpashchenkov
Copy link
Contributor Author

mpashchenkov commented Sep 24, 2021

@fzhar, @ivikhrev Can you give some recommendations about CMakeLists.txt graph? I missed some steps (see to failed Windows build).

@mpashchenkov
Copy link
Contributor Author

Also i can't fix Win10 red build (some problems with Yolo network isn't part of this PR).

@ivikhrev
Copy link

Also i can't fix Win10 red build (some problems with Yolo network isn't part of this PR).

yeah, I also noticed it. @akorobeinikov is going to fix it today.

@ivikhrev
Copy link

ivikhrev commented Sep 24, 2021

@fzhar, @ivikhrev Can you give some recommendations about CMakeLists.txt graph? I missed some steps (see to failed Windows build).

@mpashchenkov , yout can't create a library without .cpp file, create src folder and put a cpp file there with
#include <utils_gapi/stream_source.hpp> .

utils folder should be renamed to utils_gapi.

CMakeLists.txt in cpp_gapi/utils_gapi should be the next:

# Copyright (C) 2021 Intel Corporation
# SPDX-License-Identifier: Apache-2.0
#

file(GLOB_RECURSE HEADERS "${CMAKE_CURRENT_SOURCE_DIR}/include/*")
file(GLOB_RECURSE SOURCES "${CMAKE_CURRENT_SOURCE_DIR}/src/*")

source_group("src" FILES ${SOURCES})
source_group("include" FILES ${HEADERS})

add_library(utils_gapi STATIC ${HEADERS} ${SOURCES})
target_include_directories(utils_gapi PUBLIC "${CMAKE_CURRENT_SOURCE_DIR}/include")
target_link_libraries(utils_gapi PRIVATE gflags ${InferenceEngine_LIBRARIES} opencv_core utils)

@vladimir-dudnik
Copy link
Contributor

@mpashchenkov yolo warnings were fixed in #2654, please rebase your branch to develop

@fzhar
Copy link
Contributor

fzhar commented Sep 27, 2021

as for windows build - you have many "warning treated as error" warnings. Just check them in the build log and fix them

demos/interactive_face_detection_demo/cpp_gapi/main.cpp Outdated Show resolved Hide resolved
demos/interactive_face_detection_demo/cpp_gapi/main.cpp Outdated Show resolved Hide resolved
demos/interactive_face_detection_demo/cpp_gapi/utils.hpp Outdated Show resolved Hide resolved
demos/common/cpp_gapi/utils_gapi/src/stream_source.cpp Outdated Show resolved Hide resolved
demos/CMakeLists.txt Outdated Show resolved Hide resolved
@Wovchena Wovchena merged commit 45f34f6 into openvinotoolkit:develop Nov 15, 2021
@mpashchenkov
Copy link
Contributor Author

@OrestChura, FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
demo Issues with demo results, performance and etc. refactoring Refactor of anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants