-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
G-API. Common StreamSource. IFD-GAPI small refactoring. #2778
Conversation
@@ -4,15 +4,14 @@ | |||
|
|||
#include <monitors/presenter.h> | |||
#include <utils/args_helper.hpp> | |||
#include <utils/slog.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slog
is still used in this demo, it should be directly included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, it seems, I forgot to include it directly in the smart_classroom_demo_gapi, when modified it. Can you add it here also, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files have dependencies with slog.hpp, m b, because this works fine. This include is returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
face_inference_results.hpp contains this file for gaze_estimation
and
custom_kernels.hpp for smart_classroom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivikhrev Could the thread will be resolved?
Also i can't fix Win10 red build (some problems with Yolo network isn't part of this PR). |
yeah, I also noticed it. @akorobeinikov is going to fix it today. |
@mpashchenkov , yout can't create a library without .cpp file, create src folder and put a cpp file there with
|
@mpashchenkov yolo warnings were fixed in #2654, please rebase your branch to develop |
as for windows build - you have many "warning treated as error" warnings. Just check them in the build log and fix them |
f76c4c4
to
c442ce3
Compare
demos/common/cpp_gapi/utils_gapi/include/utils_gapi/stream_source.hpp
Outdated
Show resolved
Hide resolved
ac9c8a7
to
154ceaf
Compare
@OrestChura, FYI. |
PR provides common stream_source class which is used for all G-API demos. Implementation is questionable (CMakeLists should have some standards, which i haven't followed. I hope review help me with this).
Also PR contains small refactoring for Interactive Face detection G-API demo:
parseSSD
kernel;ImagesCapture
OMZ common class instead ofSetInput()
.