Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add modelAPI to pedestian_tracker_demo #2654

Merged
merged 28 commits into from
Sep 24, 2021
Merged

add modelAPI to pedestian_tracker_demo #2654

merged 28 commits into from
Sep 24, 2021

Conversation

VoronovaIntern
Copy link
Contributor

@VoronovaIntern VoronovaIntern commented Aug 2, 2021 •
edited by vladimir-dudnik
Loading

redesign demo to OMZ Model API approach

  • apply Model API wrappers for detection models
  • apply Model API wrappers for reidentification models (this postponed until model api architecture discussion)

@openvino-pushbot
Copy link
Contributor

Can one of the admins verify this patch?

@ivikhrev
Copy link

ivikhrev commented Aug 2, 2021

Pls, rebase to the latest develop

@ivikhrev
Copy link

ivikhrev commented Aug 4, 2021

Jenkins ok to test

ivikhrev
ivikhrev reviewed Aug 11, 2021
View reviewed changes
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
@vladimir-dudnik
Copy link
Contributor

pre-commit check failed
10:39:44 RuntimeError: demos/pedestrian_tracker_demo/cpp/README.md: "efficientdet-d0-tf" model reference is missing. Add it to README.md or update models.lst file.

anzhella-pankratova
anzhella-pankratova suggested changes Aug 24, 2021
View reviewed changes
demos/pedestrian_tracker_demo/cpp/CMakeLists.txt Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/main.cpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/include/pedestrian_tracker_demo.hpp Outdated Show resolved Hide resolved
demos/pedestrian_tracker_demo/cpp/include/pedestrian_tracker_demo.hpp Outdated Show resolved Hide resolved
vladimir-dudnik
vladimir-dudnik reviewed Aug 31, 2021
View reviewed changes
Copy link
Contributor

@vladimir-dudnik vladimir-dudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VoronovaIntern please add 2021 to copyrights for affected files

@github-actions github-actions bot added demo Issues with demo results, performance and etc. documentation documentation updates, improvements and fixes labels Sep 22, 2021
@vladimir-dudnik
Copy link
Contributor

Jenkins please retry a build

vladimir-dudnik
vladimir-dudnik suggested changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@vladimir-dudnik vladimir-dudnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add -at ssd to the sample command

./pedestrian_tracker_demo -i <path_video_file> \
                          -m_det <path_to_model>/person-detection-retail-0013.xml \
                          -m_reid <path_to_model>/person-reidentification-retail-0277.xml \
                          -d_det GPU

demos/pedestrian_tracker_demo/cpp/README.md Outdated Show resolved Hide resolved
@VoronovaIntern
Copy link
Contributor Author

@vladimir-dudnik before me

Please also add -at ssd to the sample command

./pedestrian_tracker_demo -i <path_video_file> \
                          -m_det <path_to_model>/person-detection-retail-0013.xml \
                          -m_reid <path_to_model>/person-reidentification-retail-0277.xml \
                          -d_det GPU

done

@vladimir-dudnik vladimir-dudnik merged commit 0ed9484 into openvinotoolkit:develop Sep 24, 2021
This was referenced Sep 24, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivikhrev ivikhrev ivikhrev left review comments

@vladimir-dudnik vladimir-dudnik vladimir-dudnik approved these changes

@anzhella-pankratova anzhella-pankratova anzhella-pankratova approved these changes

Assignees
No one assigned
Labels
demo Issues with demo results, performance and etc. documentation documentation updates, improvements and fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VoronovaIntern @openvino-pushbot @ivikhrev @vladimir-dudnik @anzhella-pankratova