Removes Zipkin from quick start and tracer list #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#260 will fix this |
This should help reduce confusion that Zipkin is an OpenTracing project, that it is a tracer (it is a system), and any conflation that a single non-contrib tracer in the OpenZipkin org means we support or are supported by OpenTracing.
|
changed the example, which for some reason is in a different repo, and different than the quick start here. opentracing-contrib/examples#1 |
JStickler
reviewed
Apr 6, 2018
| @@ -8,7 +8,7 @@ Both of these examples assume that Jaeger is running locally via Docker: | |||
| $ docker run -d -p 5775:5775/udp -p 16686:16686 jaegertracing/all-in-one:latest | |||
| ``` | |||
|
|
|||
| These can be adapted to use Zipkin or any other OpenTracing-compatible Tracer easily by adjusting the initialization code to match the particular implementation. | |||
| These can be adapted to use other OpenTracing-compatible Tracer easily by adjusting the initialization code to match the particular implementation. | |||
There was a problem hiding this comment.
Subject/verb agreement
"These can be adapted to use other OpenTracing-compatible Tracers"
or
"These can be adapted to use any other OpenTracing-compatible Tracer"
There was a problem hiding this comment.
It's ok, we can fix this later.
"fix it in post" :)
|
Sorry to see you go @adriancole. Hopefully later, when things are stable, you will find OT instrumentation useful for the Zipkin community. Please let me know if there is anything else I can do for you. |
|
thanks, Ted and great attitude! much appreciated
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help reduce confusion that Zipkin is an OpenTracing project,
that it is a tracer (it is a system), and any conflation that a single non-contrib
tracer in the OpenZipkin org means we support or are supported by OpenTracing.
Personally, I'm also removing my talk as I am not interested in
indirectly endorsing this project.
Fixes #258
Fixes #257 (though the referenced repo should switch to jeager tracer)