Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

NoopSpanBuilder does not need to inherit from SpanContext. #290

Merged
merged 1 commit into from
Jul 24, 2018
Merged

NoopSpanBuilder does not need to inherit from SpanContext. #290

merged 1 commit into from
Jul 24, 2018

Conversation

carlosalberto
Copy link
Collaborator

Would fix #255

@yurishkuro ;)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 74.112% when pulling 10a04c4 on carlosalberto:noopspanbuilder_nospancontext into 3e78ba6 on opentracing:master.

@yurishkuro yurishkuro merged commit d988630 into opentracing:master Jul 24, 2018
tylerbenson added a commit that referenced this pull request Dec 5, 2018
@tylerbenson
Revert "NoopSpanBuilder does not need to inherit from SpanContext. (#290
5ee59b8 
)"

This reverts commit d988630.
@carlosalberto carlosalberto deleted the noopspanbuilder_nospancontext branch March 7, 2019 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@tylerbenson tylerbenson tylerbenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should NoopSpanBuilder still extend NoopSpanContext?
4 participants
@carlosalberto @coveralls @tylerbenson @yurishkuro